Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: user could buy empty domain #53

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: user could buy empty domain #53

merged 1 commit into from
May 28, 2024

Conversation

irisdv
Copy link
Collaborator

@irisdv irisdv commented May 21, 2024

Close #46

For now I checked that domain_len is different than 0 in buy and altcoin_buy. Do you think we should also add this check in the renew functions ?

For the creation of subdomains, we could loop through the domain array received in transfer_domain function to check that we don't have any parts that are equal to 0 ?

@irisdv irisdv requested a review from Th0rgal May 21, 2024 07:47
@irisdv irisdv added the 🔥 Ready for review Pull Request needs a label May 21, 2024
@Th0rgal Th0rgal merged commit 052aabe into master May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Th0rgal Th0rgal Th0rgal approved these changes

Assignees
No one assigned
Labels
🔥 Ready for review Pull Request needs a
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[audit] User could buy empty domain
2 participants
@irisdv @Th0rgal